Report yanks for cached and resolved packages

crates/distribution-types/src/resolved.rs

@@ -1,6 +1,7 @@
 use std::fmt::{Display, Formatter};
 
 use pep508_rs::PackageName;
+use pypi_types::Yanked;
 
 use crate::{
     BuiltDist, Dist, DistributionId, DistributionMetadata, Identifier, IndexUrl, InstalledDist,
@@ -51,6 +52,18 @@ impl ResolvedDist {
             Self::Installed(_) => None,
         }
     }
+
+    /// Returns the [`Yanked`] status of the distribution, if available.
+    pub fn yanked(&self) -> Option<&Yanked> {
+        match self {
+            Self::Installable(dist) => match dist {
+                Dist::Source(SourceDist::Registry(sdist)) => sdist.file.yanked.as_ref(),
+                Dist::Built(BuiltDist::Registry(wheel)) => wheel.best_wheel().file.yanked.as_ref(),
+                _ => None,
+            },
+            Self::Installed(_) => None,
+        }
+    }
 }
 
 impl ResolvedDistRef<'_> {

crates/uv-resolver/src/resolution/graph.rs

@@ -12,6 +12,7 @@ use distribution_types::{
 };
 use pep440_rs::{Version, VersionSpecifier};
 use pep508_rs::MarkerEnvironment;
+use pypi_types::Yanked;
 use uv_normalize::{ExtraName, PackageName};
 
 use crate::dependency_provider::UvDependencyProvider;
@@ -56,6 +57,30 @@ impl ResolutionGraph {
         let mut diagnostics = Vec::new();
         for (package, version) in selection {
             match &**package {
+                PubGrubPackageInner::Package {
+                    name,
+                    extra: None,
+                    marker: None,
+                    url: None,
+                } => {
+                    let dist = pins
+                        .get(name, version)
+                        .expect("Every package should be pinned")
+                        .clone();
+
+                    match dist.yanked() {
+                        None | Some(Yanked::Bool(false)) => {}
+                        Some(Yanked::Bool(true)) => {
+                            diagnostics.push(Diagnostic::YankedVersion { reason: None, dist });
+                        }
+                        Some(Yanked::Reason(reason)) => {
+                            diagnostics.push(Diagnostic::YankedVersion {
+                                reason: Some(reason.clone()),
+                                dist,
+                            });
+                        }
+                    }
+                }
                 PubGrubPackageInner::Package {
                     name,
                     extra: Some(extra),
@@ -580,12 +605,18 @@ impl From<ResolutionGraph> for distribution_types::Resolution {
 #[derive(Debug)]
 pub enum Diagnostic {
     MissingExtra {
-        /// The distribution that was requested with an non-existent extra. For example,
+        /// The distribution that was requested with a non-existent extra. For example,
         /// `black==23.10.0`.
         dist: ResolvedDist,
         /// The extra that was requested. For example, `colorama` in `black[colorama]`.
         extra: ExtraName,
     },
+    YankedVersion {
+        /// The package that was requested with a yanked version. For example, `black==23.10.0`.
+        dist: ResolvedDist,
+        /// The reason that the version was yanked, if any.
+        reason: Option<String>,
+    },
 }
 
 impl Diagnostic {
@@ -595,13 +626,21 @@ impl Diagnostic {
             Self::MissingExtra { dist, extra } => {
                 format!("The package `{dist}` does not have an extra named `{extra}`.")
             }
+            Self::YankedVersion { dist, reason } => {
+                if let Some(reason) = reason {
+                    format!("`{dist}` is yanked (reason: \"{reason}\").")
+                } else {
+                    format!("`{dist}` is yanked.")
+                }
+            }
         }
     }
 
     /// Returns `true` if the [`PackageName`] is involved in this diagnostic.
     pub fn includes(&self, name: &PackageName) -> bool {
         match self {
             Self::MissingExtra { dist, .. } => name == dist.name(),
+            Self::YankedVersion { dist, .. } => name == dist.name(),
         }
     }
 }

crates/uv/src/commands/pip/operations.rs

@@ -9,7 +9,7 @@ use owo_colors::OwoColorize;
 use tracing::debug;
 
 use distribution_types::{
-    CachedDist, Dist, InstalledDist, Requirement, UnresolvedRequirementSpecification,
+    CachedDist, InstalledDist, Requirement, UnresolvedRequirementSpecification,
 };
 use distribution_types::{
     DistributionMetadata, IndexLocations, InstalledMetadata, InstalledVersion, LocalDist, Name,
@@ -19,7 +19,6 @@ use install_wheel_rs::linker::LinkMode;
 use pep440_rs::{VersionSpecifier, VersionSpecifiers};
 use pep508_rs::{MarkerEnvironment, VerbatimUrl};
 use platform_tags::Tags;
-use pypi_types::Yanked;
 use uv_cache::Cache;
 use uv_client::{BaseClientBuilder, RegistryClient};
 use uv_configuration::{
@@ -523,8 +522,6 @@ pub(crate) async fn install(
 
     report_modifications(wheels, reinstalls, extraneous, printer)?;
 
-    report_yanks(&remote, printer)?;
-
     Ok(())
 }
 
@@ -666,8 +663,6 @@ fn report_dry_run(
         }
     }
 
-    report_yanks(&remote, printer)?;
-
     Ok(())
 }
 
@@ -721,37 +716,6 @@ pub(crate) fn report_modifications(
     Ok(())
 }
 
-/// Report on any yanked distributions in the resolution.
-pub(crate) fn report_yanks(remote: &[Dist], printer: Printer) -> Result<(), Error> {
-    // TODO(konstin): Also check the cache whether any cached or installed dist is already known to
-    // have been yanked, we currently don't show this message on the second run anymore
-    for dist in remote {
-        let Some(file) = dist.file() else {
-            continue;
-        };
-        match &file.yanked {
-            None | Some(Yanked::Bool(false)) => {}
-            Some(Yanked::Bool(true)) => {
-                writeln!(
-                    printer.stderr(),
-                    "{}{} {dist} is yanked.",
-                    "warning".yellow().bold(),
-                    ":".bold(),
-                )?;
-            }
-            Some(Yanked::Reason(reason)) => {
-                writeln!(
-                    printer.stderr(),
-                    "{}{} {dist} is yanked (reason: \"{reason}\").",
-                    "warning".yellow().bold(),
-                    ":".bold(),
-                )?;
-            }
-        }
-    }
-    Ok(())
-}
-
 /// Report any diagnostics on installed distributions in the Python environment.
 pub(crate) fn report_diagnostics(
     resolution: &Resolution,

crates/uv/tests/pip_compile.rs

@@ -2805,6 +2805,7 @@ fn compile_yanked_version_direct() -> Result<()> {
 
     ----- stderr -----
     Resolved 1 package in [TIME]
+    warning: `attrs==21.1.0` is yanked (reason: "Installable but not importable on Python 3.4.").
     "###
     );