warning: VIRTUAL_ENV ignored

[danielhollas]

When running uv 0.5.16 using this pre-commit hook I get the following warning:

warning: `VIRTUAL_ENV=/home/hollas/.cache/pre-commit/repovyb9qrvk/py_env-python3.12` does not match the project environment path `.venv` and will be ignored

I understand why the warning is there, but I suspect it could be quite confusing for new users. It would be great if this warning could be somehow disabled when uv is run within pre-commit virtual environment.

[danielhollas]

Maybe something like a hidden uv option --ignore-activated-virtualenv that would get rid of the warning?

[zanieb]

How is the uv command being invoked? Can the VIRTUAL_ENV variable just be cleared?

[danielhollas]

How is the uv command being invoked? Can the VIRTUAL_ENV variable just be cleared?

I don't think so. :-( If I just naively modify the hook entry here

uv-pre-commit/.pre-commit-hooks.yaml

Line 14 in 6ebd8b3

entry: uv lock

to

 entry: VIRTUAL_ENV= uv lock 

pre-commit will fail even before the actual invocation since it does a bunch of cmd normalization that assumes that the first entry argument is an executable. e.g.

https://github.com/pre-commit/pre-commit/blob/aba1ce04e70162ca48b12f809ceffb253b788fe6/pre_commit/xargs.py#L150

[zanieb]

I think you'd use env -u (pre-commit/pre-commit#2367 (comment))

❯ export VIRTUAL_ENV=foo
❯ /bin/bash -c 'echo "$VIRTUAL_ENV"'
foo
❯ env -u VIRTUAL_ENV /bin/bash -c 'echo "$VIRTUAL_ENV"'

[danielhollas]

Ah, sorry, should have searched better. But as the last commenter on that issue mentions, is that portable?

I briefly went through theany related iasues on the pre-commit issue tracker and haven't seen a workaround that would be portable (but my knowledge of how Windows does things is minimal so I might be wrong)

[zanieb]

I'm not sure, but that seems like a pre-commit issue? Not letting people set environment variables in a cross-platform way seems problematic and I'm hesitant to go out of my way to account for that.

I suppose if I land astral-sh/uv#11189 I can add a --no-active option which would silence the warning.

[danielhollas]

Oh yeah, totally agree, and I am not trying to push for a solution from a uv side, just documenting my findings. At the same time, it's quite clear that the feature has been requested, and rejected, on the pre-commit issue tracker many times, so that's a dead end, sigh.

…

On Mon, Feb 3, 2025, 23:37 Zanie Blue ***@***.***> wrote: I'm not sure, but that seems like a pre-commit issue? I suppose if I land astral-sh/uv#11189 <astral-sh/uv#11189> I can add a --no-active option which would silence the warning. — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIY64PJ7OD3S4NPHORACY32N74SPAVCNFSM6AAAAABU6YMDP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZSGQYTSNBSGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[danielhollas]

@zanieb I think this issue should be re-opened until #43 get's merged and released (I guess until next uv version is cut)