Repository navigation
Conversation
astral-automations-bot
Bot
added
area:windows
zaniebot
changed the base branch from
main
to
zb/regression-windows-long-paths-21611
September 11, 2026 19:13
zanieb
added this pull request to stack #1457
September 11, 2026 19:16
zaniebot
force-pushed
the
zb/fix-windows-long-paths-21611
branch
from
September 11, 2026 19:17
8180464 to
b4a19d1
Compare
woodruffw
reviewed
Sep 11, 2026
Comment on lines
-4149
to
4153
| // A valid wheel fails when either its destination or temporary-file path exceeds | ||
| // MAX_PATH. This should succeed even without the opt-in; see astral-sh/uv#21611. | ||
| // Both the destination and the temporary-file path can exceed MAX_PATH. Neither | ||
| // should require the long-path opt-in; see astral-sh/uv#21611. | ||
| uv_snapshot!(context.filters(), context.pip_install() | ||
| .arg("--no-index") | ||
| .arg("--link-mode") | ||
| .arg("copy") | ||
| .arg(&filename), @" | ||
| exit_code: 2 (failure) | ||
| exit_code: 0 (success) | ||
| ----- stderr ----- | ||
| Resolved 1 package in [TIME] | ||
| Prepared 1 package in [TIME] | ||
| error: Failed to install: long_paths-1.0.0-py3-none-any.whl (long-paths==1.0.0 (from file://[TEMP_DIR]/long_paths-1.0.0-py3-none-any.whl)) | ||
| Caused by: Failed to copy to `[LONG_PATH]` | ||
| Caused by: Failed to persist temporary file to [LONG_PATH]: failed to persist temporary file: The system cannot find the path specified. (os error 3) | ||
| Installed 1 package in [TIME] | ||
| + long-paths==1.0.0 (from file://[TEMP_DIR]/long_paths-1.0.0-py3-none-any.whl) | ||
| "); |
Member
There was a problem hiding this comment.
Huh, so at some point we regressed this snapshot without noticing?
Member
There was a problem hiding this comment.
The test is introduced in the stack parent
zaniebot
added
risk:3
zaniebot
force-pushed
the
zb/fix-windows-long-paths-21611
branch
from
September 11, 2026 23:46
b4a19d1 to
db18855
Compare
charliermarsh
marked this pull request as ready for review
September 11, 2026 23:51
|
Waiting for promotion of parent #1456 |
|
Promoted to #21625. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows images with
LongPathsEnabled=0,uv pip install jupyterlab-widgets==3.0.16can fail when the package's nested frontend assets exceedMAX_PATHunder the virtual environment. In0.12.11, astral-sh#21468 moved merged copies toNamedTempFile::persist, which passes paths directly to Win32 rather than applying Rust's long-path conversion. Convert the copy destination to a verbatim path before creating its temporary file, so both paths passed topersistsupport long paths without changing the atomic replacement or retry behavior.Fixes astral-sh#21611.