Skip to content

Use ICF for macOS release builds - #3709

Merged
charliermarsh merged 1 commit into
astral-sh:mainfrom
zaniebot:zb/macos-icf-release-builds
Jul 1, 2026
Merged

Use ICF for macOS release builds#3709
charliermarsh merged 1 commit into
astral-sh:mainfrom
zaniebot:zb/macos-icf-release-builds

Conversation

@zaniebot

@zaniebot zaniebot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Use Rust's bundled Mach-O LLD with --icf=safe for macOS release builds.

The workflow scopes the linker flags to the macOS wheel builds.

Related uv change: astral-sh/uv#19615

CI Results

Build binaries run: https://github.com/astral-sh/ty/actions/runs/27213899750

Measured with a same-commit A/B release build on a Namespace macOS ARM machine, using maturin 1.13.3 and Rust 1.96. The x86_64 row was cross-built from the ARM machine.

Target Binary size Binary delta Wheel size Wheel delta
macos-x86_64 22.99 MiB -0.26 MiB (-1.10%) 10.91 MiB -0.04 MiB (-0.40%)
macos-aarch64 21.52 MiB -0.14 MiB (-0.66%) 10.40 MiB +0.01 MiB (+0.07%)

The binary size measures installed/on-disk impact; the wheel size measures network/download size.

@zaniebot
zaniebot force-pushed the zb/macos-icf-release-builds branch from c554401 to 5bdb1b8 Compare June 9, 2026 16:48
@zaniebot
zaniebot force-pushed the zb/macos-icf-release-builds branch from 5bdb1b8 to 307515e Compare June 9, 2026 16:56
@zanieb zanieb closed this Jun 24, 2026
@zanieb zanieb reopened this Jun 26, 2026
@zanieb
zanieb marked this pull request as ready for review June 26, 2026 16:22
@charliermarsh charliermarsh added the performance Potential performance improvement label Jul 1, 2026
@charliermarsh
charliermarsh merged commit 9dcb48b into astral-sh:main Jul 1, 2026
44 of 52 checks passed
charliermarsh added a commit that referenced this pull request Jul 1, 2026
Reverts #3709 to see if this unblocks the release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants