Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,6 @@ Currently, the extension supports the following features:
- Inlay hints for assignment targets
- Completions

> **Note:**
>
> Completions is an experimental feature and requires explicit opt-in to be enabled via the
> following setting in your `settings.json`:
>
> ```json
> {
> "ty.experimental.completions.enable": true
> }
> ```

> **Note:**
>
> If you want to test the language server features like completions, go to type definition, etc., it's
Expand Down
6 changes: 0 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,6 @@
"scope": "window",
"type": "boolean"
},
"ty.experimental.completions.enable": {
"default": false,
"markdownDescription": "Whether to enable completions.",
"scope": "window",
"type": "boolean"
},
"ty.importStrategy": {
"default": "fromEnvironment",
"markdownDescription": "Strategy for loading the `ty` executable. `fromEnvironment` picks up ty from the environment, falling back to the bundled version if needed. `useBundled` uses the version bundled with the extension.",
Expand Down
9 changes: 0 additions & 9 deletions src/common/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ type ImportStrategy = "fromEnvironment" | "useBundled";

type LogLevel = "error" | "warn" | "info" | "debug" | "trace";

type Experimental = {
completions?: {
enable?: boolean;
};
};

type PythonSettings = {
ty?: {
disableLanguageServices?: boolean;
Expand All @@ -32,7 +26,6 @@ export interface ISettings {
importStrategy: ImportStrategy;
logLevel?: LogLevel;
logFile?: string;
experimental?: Experimental;
python?: PythonSettings;
}

Expand Down Expand Up @@ -126,7 +119,6 @@ export async function getWorkspaceSettings(
importStrategy: config.get<ImportStrategy>("importStrategy") ?? "fromEnvironment",
logLevel: config.get<LogLevel>("logLevel"),
logFile: config.get<string>("logFile"),
experimental: config.get<Experimental>("experimental"),
python: getPythonSettings(workspace),
};
}
Expand All @@ -151,7 +143,6 @@ export async function getGlobalSettings(namespace: string): Promise<ISettings> {
importStrategy: getGlobalValue<ImportStrategy>(config, "importStrategy", "fromEnvironment"),
logLevel: getOptionalGlobalValue<LogLevel>(config, "logLevel"),
logFile: getOptionalGlobalValue<string>(config, "logFile"),
experimental: getOptionalGlobalValue<Experimental>(config, "experimental"),
python: getPythonSettings(),
};
}
Expand Down