Merged
Conversation
In #2, we accidentally changed the `target_base` from the target base to the parent of the file. This would cause hardlink unpacking to fail. Example: A hardlink at `hardlinked-0.1.0/pyproject.toml` pointing to `hardlinked-0.1.0/pyproject.toml.real` would try pointing to `hardlinked-0.1.0/`hardlinked-0.1.0/pyproject.toml.real` instead and fail the unpacking. [future edit: uv companion PR with test]
konstin
force-pushed
the
konsti/fix-hardlink-unpacking
branch
from
824b4d7 to
d6be1ad
Compare
charliermarsh
approved these changes
Feb 4, 2025
Member
charliermarsh
left a comment
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks! When you merge, please create a tag with the first seven characters of the commit SHA.
Member
Author
|
I'll follow-up with a test case in this repo, too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2, we accidentally changed the
target_basefrom the target base to the parent of the file. This would cause hardlink unpacking to fail.Example: A hardlink at
hardlinked-0.1.0/pyproject.tomlpointing tohardlinked-0.1.0/pyproject.toml.realwould try pointing tohardlinked-0.1.0/hardlinked-0.1.0/pyproject.toml.realinstead and fail the unpacking.uv companion PR with test: astral-sh/uv#11221