Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in .python-version #1038

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Allow comments in .python-version #1038

merged 1 commit into from
Apr 24, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Apr 24, 2024

Summary

pyenv allows comments in .python-version files, so Rye will now skip commented-out lines.

Note that not all tools support this. For example, mise does not.

Closes #1032.

@charliermarsh charliermarsh added the bug Something isn't working label Apr 24, 2024
@charliermarsh charliermarsh merged commit 7c01d34 into main Apr 24, 2024
@charliermarsh charliermarsh deleted the charlie/comments branch April 24, 2024 13:52
zanieb pushed a commit to astral-sh/uv that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of ".python-version" file does not respect comments
2 participants