Skip to content

Remove StringKind::FString and StringKind::RawFString#7667

Merged
dhruvmanila merged 1 commit intodhruv/pep-701from
dhruv/remove-fstring-kind
Sep 26, 2023
Merged

Remove StringKind::FString and StringKind::RawFString#7667
dhruvmanila merged 1 commit intodhruv/pep-701from
dhruv/remove-fstring-kind

Conversation

@dhruvmanila
Copy link
Member

Summary

This PR removes the now unused StringKind::FString and StringKind::RawFString
enum variants.

Test Plan

cargo test

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Sep 26, 2023
assert_debug_snapshot!(tokens);
}

#[test]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I messed up my last rebase 😓

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 26, 2023

CodSpeed Performance Report

Merging #7667 will degrade performances by 3.88%

Comparing dhruv/remove-fstring-kind (a9230df) with dhruv/pep-701 (917cace)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark dhruv/pep-701 dhruv/remove-fstring-kind Change
linter/default-rules[large/dataset.py] 91.9 ms 95.6 ms -3.88%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants