Remove StringKind::FString and StringKind::RawFString#7667
Merged
dhruvmanila merged 1 commit intodhruv/pep-701from Sep 26, 2023
Merged
Remove StringKind::FString and StringKind::RawFString#7667dhruvmanila merged 1 commit intodhruv/pep-701from
StringKind::FString and StringKind::RawFString#7667dhruvmanila merged 1 commit intodhruv/pep-701from
Conversation
This was referenced Sep 26, 2023
Member
Author
This was referenced Sep 26, 2023
dhruvmanila
commented
Sep 26, 2023
| assert_debug_snapshot!(tokens); | ||
| } | ||
|
|
||
| #[test] |
Member
Author
There was a problem hiding this comment.
Sorry, I messed up my last rebase 😓
CodSpeed Performance ReportMerging #7667 will degrade performances by 3.88%Comparing Summary
Benchmarks breakdown
|
MichaReiser
approved these changes
Sep 26, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 27, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 28, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 29, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR removes the now unused
StringKind::FStringandStringKind::RawFStringenum variants.
Test Plan
cargo test