Don't detect pandas#values for stores, deletes, or class accesses

crates/ruff/src/checkers/ast/analyze/expression.rs

@@ -261,7 +261,7 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
                 pylint::rules::load_before_global_declaration(checker, id, expr);
             }
         }
-        Expr::Attribute(ast::ExprAttribute { attr, value, .. }) => {
+        Expr::Attribute(attribute) => {
             // Ex) typing.List[...]
             if checker.any_enabled(&[
                 Rule::FutureRewritableTypeAnnotation,
@@ -323,7 +323,7 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
             if checker.enabled(Rule::CollectionsNamedTuple) {
                 flake8_pyi::rules::collections_named_tuple(checker, expr);
             }
-            pandas_vet::rules::attr(checker, attr, value, expr);
+            pandas_vet::rules::attr(checker, attribute);
         }
         Expr::Call(
             call @ ast::ExprCall {

crates/ruff/src/rules/pandas_vet/helpers.rs

@@ -30,8 +30,15 @@ pub(super) fn test_expression(expr: &Expr, semantic: &SemanticModel) -> Resoluti
                 .resolve_name(name)
                 .map_or(Resolution::IrrelevantBinding, |id| {
                     match &semantic.binding(id).kind {
+                        BindingKind::Argument => {
+                            // Avoid, e.g., `self.values`.
+                            if matches!(name.id.as_str(), "self" | "cls") {
+                                Resolution::IrrelevantBinding
+                            } else {
+                                Resolution::RelevantLocal
+                            }
+                        }
                         BindingKind::Annotation
-                        | BindingKind::Argument
                         | BindingKind::Assignment
                         | BindingKind::NamedExprAssignment
                         | BindingKind::UnpackedAssignment

crates/ruff/src/rules/pandas_vet/mod.rs

@@ -209,6 +209,23 @@ mod tests {
     "#,
         "PD011_pass_values_call"
     )]
+    #[test_case(
+        r#"
+        import pandas as pd
+        x = pd.DataFrame()
+        x.values = 1
+    "#,
+        "PD011_pass_values_store"
+    )]
+    #[test_case(
+        r#"
+        class Class:
+            def __init__(self, values: str) -> None:
+                self.values = values
+                print(self.values)
+    "#,
+        "PD011_pass_values_instance"
+    )]
     #[test_case(
         r#"
         import pandas as pd

crates/ruff/src/rules/pandas_vet/rules/attr.rs

@@ -1,4 +1,4 @@
-use ruff_python_ast::{Expr, Ranged};
+use ruff_python_ast::{self as ast, Expr, ExprContext, Ranged};
 
 use ruff_diagnostics::Violation;
 use ruff_diagnostics::{Diagnostic, DiagnosticKind};
@@ -44,8 +44,14 @@ impl Violation for PandasUseOfDotValues {
     }
 }
 
-pub(crate) fn attr(checker: &mut Checker, attr: &str, value: &Expr, attr_expr: &Expr) {
-    let violation: DiagnosticKind = match attr {
+pub(crate) fn attr(checker: &mut Checker, attribute: &ast::ExprAttribute) {
+    // Avoid, e.g., `x.values = y`.
+    if matches!(attribute.ctx, ExprContext::Store | ExprContext::Del) {
+        return;
+    }
+
+    let violation: DiagnosticKind = match attribute.attr.as_str() {
+        // PD011
         "values" if checker.settings.rules.enabled(Rule::PandasUseOfDotValues) => {
             PandasUseOfDotValues.into()
         }
@@ -62,13 +68,13 @@ pub(crate) fn attr(checker: &mut Checker, attr: &str, value: &Expr, attr_expr: &
     // Avoid flagging on non-DataFrames (e.g., `{"a": 1}.values`), and on irrelevant bindings
     // (like imports).
     if !matches!(
-        test_expression(value, checker.semantic()),
+        test_expression(attribute.value.as_ref(), checker.semantic()),
         Resolution::RelevantLocal
     ) {
         return;
     }
 
     checker
         .diagnostics
-        .push(Diagnostic::new(violation, attr_expr.range()));
+        .push(Diagnostic::new(violation, attribute.range()));
 }

crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_values_instance.snap

@@ -0,0 +1,4 @@
+---
+source: crates/ruff/src/rules/pandas_vet/mod.rs
+---
+

crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_values_store.snap

@@ -0,0 +1,4 @@
+---
+source: crates/ruff/src/rules/pandas_vet/mod.rs
+---
+