Override fmt_dangling_comments for frequent nodes#6551
Merged
MichaReiser merged 1 commit intomainfrom Aug 14, 2023
Merged
Conversation
This was referenced Aug 14, 2023
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
konstin
approved these changes
Aug 14, 2023
Contributor
PR Check ResultsBenchmarkLinuxWindows |
222bf7d to
a97a59a
Compare
Merged
a97a59a to
3076d97
Compare
1297472 to
3ac7ec7
Compare
3076d97 to
2db43a5
Compare
3ac7ec7 to
69e3a16
Compare
2db43a5 to
493a3b6
Compare
69e3a16 to
e015620
Compare
e015620 to
e029db8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
I noticed that
fmt_dangling_commentsforExprNameandExprCompareshows up in flamegraphs.This PR overrides
fmt_dangling_commentsfor these expressions as we know that they can't have dangling comments. This comes at the riskthat we may drop such comment if this ever happens to change, but we have the
assert_formatted_all_commentsin debug builds that helps us catch unformatted comments.Test Plan
cargo test