[ruff] Implement quadratic-list-summation rule (RUF017)

[evanrittenhouse]

Summary

Adds RUF017. Closes #5073

Test Plan

cargo t

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                    pr
-----                                      ----                                    --
formatter/large/dataset.py                 1.01      3.6±0.30ms    11.4 MB/sec     1.00      3.5±0.30ms    11.5 MB/sec
formatter/numpy/ctypeslib.py               1.00   710.0±47.57µs    23.5 MB/sec     1.08  770.1±110.80µs    21.6 MB/sec
formatter/numpy/globals.py                 1.00     73.1±5.37µs    40.3 MB/sec     1.11    81.2±10.64µs    36.3 MB/sec
formatter/pydantic/types.py                1.00  1431.4±109.79µs    17.8 MB/sec    1.03  1471.6±129.15µs    17.3 MB/sec
linter/all-rules/large/dataset.py          1.00     12.0±0.59ms     3.4 MB/sec     1.02     12.2±0.48ms     3.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.2±0.19ms     5.1 MB/sec     1.01      3.3±0.17ms     5.1 MB/sec
linter/all-rules/numpy/globals.py          1.01   460.6±31.75µs     6.4 MB/sec     1.00   455.2±33.89µs     6.5 MB/sec
linter/all-rules/pydantic/types.py         1.05      6.3±0.34ms     4.0 MB/sec     1.00      6.0±0.36ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.02      6.3±0.32ms     6.4 MB/sec     1.00      6.2±0.33ms     6.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02  1356.0±83.04µs    12.3 MB/sec     1.00  1332.0±67.40µs    12.5 MB/sec
linter/default-rules/numpy/globals.py      1.08   174.8±11.03µs    16.9 MB/sec     1.00   162.2±10.40µs    18.2 MB/sec
linter/default-rules/pydantic/types.py     1.02      2.8±0.14ms     9.2 MB/sec     1.00      2.7±0.15ms     9.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.02      4.9±0.49ms     8.3 MB/sec    1.00      4.8±0.27ms     8.5 MB/sec
formatter/numpy/ctypeslib.py               1.04   904.5±91.24µs    18.4 MB/sec    1.00   868.4±42.46µs    19.2 MB/sec
formatter/numpy/globals.py                 1.00     86.5±3.53µs    34.1 MB/sec    1.02     87.8±3.40µs    33.6 MB/sec
formatter/pydantic/types.py                1.00  1761.7±79.80µs    14.5 MB/sec    1.01  1784.7±65.37µs    14.3 MB/sec
linter/all-rules/large/dataset.py          1.01     15.8±0.63ms     2.6 MB/sec    1.00     15.7±0.63ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.2±0.19ms     3.9 MB/sec    1.00      4.2±0.20ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00   488.8±20.03µs     6.0 MB/sec    1.02   497.3±36.49µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.01      8.2±0.32ms     3.1 MB/sec    1.00      8.1±0.38ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.00      8.4±0.28ms     4.8 MB/sec    1.00      8.4±0.26ms     4.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1731.8±98.74µs     9.6 MB/sec    1.00  1708.3±78.62µs     9.7 MB/sec
linter/default-rules/numpy/globals.py      1.03   200.9±13.71µs    14.7 MB/sec    1.00   194.5±13.12µs    15.2 MB/sec
linter/default-rules/pydantic/types.py     1.03      3.7±0.14ms     6.8 MB/sec    1.00      3.6±0.12ms     7.1 MB/sec

[charliermarsh]

Thanks! I tweaked this to use the functools.reduce approach suggested in the issue, since we can import symbols and I find it to be more readable (closer to sum()). I also put this in the nursery for now, I'd like to get feedback on it before we upgrade it to production.

[charliermarsh]

Oh, I'm not able to push my edits. Do you mind enabling edits, @evanrittenhouse?

[evanrittenhouse]

Sounds good - enabled edits. Didn't know we are down for importing other modules - assuming that those are built-ins only, right? Are there any contexts where we wouldn't want to do that?

[charliermarsh]

@evanrittenhouse - Good question. We can import anything from the standard library (functools and operator are both standard-library modules), but we'd never want to import anything outside of the standard library.

[hauntsaninja]

Is it intentional this only complains when start is passed by kwarg? If so, what's the reasoning?

[evanrittenhouse]

@charliermarsh I think this is from e38e8c0. Any reason we switched from arguments.find_argument("start", 1) to arguments.find_keyword("start")?

[charliermarsh]

Just my mistake, @evanrittenhouse had it right initially. I looked at the docs and saw the / for the positional-only iterable argument, and my mind immediately went to keyword-only, wasn't thinking straight. PR welcome, or I'll fix a little later.

[hauntsaninja]

Thanks both! Easy fix, will open a PR

[hauntsaninja]

#6664