-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RustPython #4900
Upgrade RustPython #4900
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsBenchmarkLinux
Windows
|
f3502c6
to
e2fcfb5
Compare
c217c0a
to
829d1c6
Compare
@@ -1,5 +1,6 @@ | |||
[workspace] | |||
members = ["crates/*"] | |||
resolver = "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust nightly complains because some workspace members use edition 2021
but the workspace does not. This fixes this warning (yes, I'm now using nightly because I can't live without CLions test runner integration)
4db87e0
to
a52d4ea
Compare
Summary
This pulls in astral-sh/RustPython-Parser#5 and astral-sh/RustPython-Parser#7. It changes RustPython to include the
(
and)
in thearguments
range and introduces a newDecorator
node.Test Plan
@
. I think that's preferred. Let me know if you prefer the way it was before.