-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize newlines in verbatim_text
#4850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2023
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+4, -0, 0 error(s)) typeshed (+4, -0)
+ stdlib/builtins.pyi:108:9: PYI029 [*] Defining `__str__` in a stub is almost always redundant
+ stdlib/builtins.pyi:109:9: PYI029 [*] Defining `__repr__` in a stub is almost always redundant
+ stdlib/distutils/version.pyi:26:9: PYI029 [*] Defining `__str__` in a stub is almost always redundant
+ stdlib/distutils/version.pyi:35:9: PYI029 [*] Defining `__str__` in a stub is almost always redundant
BenchmarkLinux
Windows
|
charliermarsh
approved these changes
Jun 5, 2023
MichaReiser
force-pushed
the
format-while-statement
branch
from
June 5, 2023 08:16
b602cdc
to
30574e1
Compare
MichaReiser
force-pushed
the
normalize-verbatim-newlines
branch
from
June 5, 2023 08:43
182ec3b
to
34892e8
Compare
MichaReiser
added
internal
An internal refactor or improvement
formatter
Related to the formatter
labels
Jun 5, 2023
konstin
pushed a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The printer requires that text elements only use '\n' line endings.
This PR ensures that
verbatim_text
properly escapes\r
or\r\n
.Test Plan