Skip to content

Enable PGO for macOS ARM64 Ruff releases - #27572

Merged
charliermarsh merged 1 commit into
charlie/ruff-pgo-prototypefrom
charlie/ruff-pgo-macos-arm64
Aug 10, 2026
Merged

charliermarsh merged 1 commit into
charlie/ruff-pgo-prototypefrom
charlie/ruff-pgo-macos-arm64

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR enables PGO for Ruff's macOS ARM64 releases, following the approach outlined in #27570. For macOS, ruff check gets 8.3% faster on the holdout set, ruff format gets 5.4% faster, and the release binary gets 1.1% smaller.

@charliermarsh
charliermarsh force-pushed the charlie/ruff-pgo-macos-arm64 branch from 2dbf8aa to 2d81158 Compare August 7, 2026 20:31
@charliermarsh
charliermarsh changed the base branch from charlie/ruff-bolt-prototype to charlie/ruff-pgo-prototype August 7, 2026 20:33
@astral-sh-bot

astral-sh-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 96.96%. The percentage of expected errors that received a diagnostic held steady at 92.96%. The number of fully passing files held steady at 106/133.

@astral-sh-bot

astral-sh-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@astral-sh-bot

astral-sh-bot Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 58 projects unchanged)

rotki/rotki (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ rotkehlchen/exchanges/okx.py:433:17: non-augmented-assignment Use `*=` to perform an augmented assignment directly

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
non-augmented-assignment 1 1 0 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh
charliermarsh force-pushed the charlie/ruff-pgo-macos-arm64 branch from 2d81158 to 5d3c2fc Compare August 7, 2026 20:56
@charliermarsh
charliermarsh marked this pull request as ready for review August 10, 2026 13:47
@charliermarsh
charliermarsh force-pushed the charlie/ruff-pgo-macos-arm64 branch from 5d3c2fc to 311be01 Compare August 10, 2026 14:11
@codspeed

codspeed Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 171 untouched benchmarks
⏩ 24 skipped benchmarks1


Comparing charlie/ruff-pgo-macos-arm64 (26f44a8) with charlie/ruff-pgo-prototype (6cf1f9d)2

Open in CodSpeed

Footnotes

  1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on charlie/ruff-pgo-prototype (cb0c3f9) during the generation of this report, so a364124 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@charliermarsh
charliermarsh force-pushed the charlie/ruff-pgo-macos-arm64 branch from 311be01 to f3be9e0 Compare August 10, 2026 14:52
@charliermarsh
charliermarsh force-pushed the charlie/ruff-pgo-macos-arm64 branch from f3be9e0 to 26f44a8 Compare August 10, 2026 14:55
@charliermarsh
charliermarsh merged commit efccf49 into main Aug 10, 2026
90 checks passed
@charliermarsh
charliermarsh deleted the charlie/ruff-pgo-macos-arm64 branch August 10, 2026 15:56
George-Ogden pushed a commit to George-Ogden/ruff that referenced this pull request Aug 16, 2026
## Summary

This PR enables PGO for Ruff's macOS ARM64 releases, following the
approach outlined in astral-sh#27570. For
macOS, `ruff check` gets 8.3% faster on the holdout set, `ruff format`
gets 5.4% faster, and the release binary gets 1.1% smaller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants