Fix indexing of excluded nested Ruff workspaces - #27303
Merged
Merged
Conversation
MichaReiser
commented
Jul 29, 2026
| // An explicitly opened workspace root must be indexed even if an ancestor | ||
| // configuration excludes it. Excluded descendants can still be skipped. | ||
| if depth > 0 | ||
| && let Some(file_name) = directory.file_name() |
Member
Author
There was a problem hiding this comment.
We skip workspace folders before where the ancestor configuration excluded them (the ancestor configuration is built above)
|
dhruvmanila
approved these changes
Jul 29, 2026
| ExtendExclude, | ||
| } | ||
|
|
||
| fn nested_workspace_server( |
Member
There was a problem hiding this comment.
It might be useful to have the function doc include the file tree it's constructing otherwise it's a little bit hard to visualize the tree structure here 😅
Thanks to Codex:
<temp_dir>/
├── .ruff.toml # exclude or extend-exclude = ["sub"]
├── test.py
├── sub/
│ ├── .ruff.toml # extend-exclude = ["foo"]
│ │ # format.quote-style = "single"
│ ├── test.py
│ └── foo/
│ └── test.py
└── unrelated/
└── test.py
| .with_file( | ||
| ".ruff.toml", | ||
| r#"target-version = "py312" | ||
| line-length = 120 |
Member
There was a problem hiding this comment.
nit: Can we reduce the line-length value here and reduce the size of the ISSUE_SOURCE content mainly for readability?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Never exclude explicitly opened workspace folders. Treat them the same as a
ruff check <excluded_folder>Fixes astral-sh/ruff-vscode#753.
Test Plan
Added E2E integration tests