Skip to content

[pylint] Add missing fix safety gotchas for non-augmented-assignment (PLR6104) #27250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 1 commit into from
Jul 28, 2026
+7 −0
Merged

[pylint] Add missing fix safety gotchas for non-augmented-assignment (PLR6104) #27250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/ruff_linter/src/rules/pylint/rules/non_augmented_assignment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@ use crate::{AlwaysFixableViolation, Edit, Fix};
/// foo += [2]
/// assert (foo, bar) == ([1, 2], [1, 2])
/// ```
///
/// An augmented assignment can also fail where the plain form succeeds. NumPy
/// writes the result into the target's buffer, so `a *= b` raises where
/// `a = a * b` would broadcast to a new shape or promote the dtype. The same
/// applies to `a @= b`, which requires the product to have the target's shape.
///
/// The fix replaces the whole statement, so any comments inside it are lost.
#[derive(ViolationMetadata)]
#[violation_metadata(preview_since = "v0.3.7")]
pub(crate) struct NonAugmentedAssignment {
Expand Down
Loading