-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add an option to opt out of human-readable names #27160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
bf02f32
b8e9cb3
8b51bcd
014923b
4541202
7056254
fee6160
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,7 @@ impl AzureRenderer<'_> { | |
| )?; | ||
| } | ||
| } | ||
| let code = if self.config.preview { | ||
| let code = if self.config.preview && !self.config.prefer_rule_codes { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We may use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, that's interesting. Codex originally tried to fold the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After thinking about this a bit more, I'm again leaning toward keeping the fields separate. In a very strict sense, we are still using Happy to follow up if you feel strongly, of course. |
||
| diag.id().as_str() | ||
| } else { | ||
| diag.secondary_code_or_id() | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.