[refurb] Allow subclassing builtins in stub files (FURB189) - #26812
Merged
Conversation
Summary -- While looking at rule stabilization candidates for 0.16, I noticed that #15291 has been blocking stabilization of this rule for quite a while despite being a one-line change. I decided to make that one-line change since it seemed sensible to me. I'll still plan to hold off on stabilization until this change has been in preview for a release cycle, but this should pave the way to stabilization in 0.17. Closed #15291 Test Plan -- New mdtest showing that the rule is inactive in stub files
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| subclass-builtin | 2 | 0 | 2 | 0 | 0 |
ntBre
marked this pull request as ready for review
July 14, 2026 19:48
MichaReiser
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While looking at rule stabilization candidates for 0.16, I noticed that #15291 has been blocking
stabilization of this rule for quite a while despite being a one-line change. I decided to make that
one-line change since it seemed sensible to me. I'll still plan to hold off on stabilization until
this change has been in preview for a release cycle, but this should pave the way to stabilization
in 0.17.
Closed #15291
Test Plan
New mdtest showing that the rule is inactive in stub files