Avoid redundant pending-indentation writes - #26774
Merged
Merged
Conversation
Memory usage reportMemory usage unchanged ✅ |
|
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
MichaReiser
approved these changes
Jul 14, 2026
Co-authored-by: Micha Reiser <micha@reiser.io>
charliermarsh
force-pushed
the
charlie/avoid-pending-indentation-write
branch
from
July 14, 2026 17:42
56b76a3 to
018ee75
Compare
charliermarsh
enabled auto-merge (squash)
July 14, 2026 17:43
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lexer checks
pending_indentationfor every token.Option::takewritesNoneeven on the common path where no indentation is pending, so we now read the field first and clear it only when a value is present. This avoids a redundant write in the hot lexer loop while preserving the existing indentation behavior.This PR is stacked on #26765 so that CodSpeed can measure the pending-indentation optimization independently.