[ruff] Clarify intentional async contexts for unused-async (RUF029) - #26641
Merged
Conversation
ntBre
changed the title
ruff] Clarify intentional async contexts for unused-async (RUF029)
ntBre
approved these changes
Jul 9, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
This looks reasonable to me, thank you!
ntBre
enabled auto-merge (squash)
July 9, 2026 23:06
auto-merge was automatically disabled
July 9, 2026 23:09
Pull request was closed
ntBre
approved these changes
Jul 9, 2026
ntBre
enabled auto-merge (squash)
July 9, 2026 23:10
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the RUF029 documentation to mention that an async function can sometimes be intentional even when it does not directly await anything.
One example is an async test or callback that needs to run inside an async execution context, such as code that uses a ContextVar.
The docs now point users toward either adding a real await when appropriate or disabling the rule for that specific function when the async boundary is intentional.
Refs #23196.
Test Plan
cargo dev generate-docscargo fmt --check --allPATH="$PWD/target/debug:$PATH" uv run --only-group dev --locked python scripts/check_docs_formatted.pyPATH="$PWD/target/debug:$PATH" uv run --only-group dev --locked prek run --files crates/ruff_linter/src/rules/ruff/rules/unused_async.rscargo test -p ruff_linter rules::ruff::tests::rules::rule_unusedasync_path_new_ruf029_py_expects