[ruff] Fix ISC003 autofix incorrectly stripping + from comments#26554
Merged
MichaReiser merged 2 commits intoJul 6, 2026
Merged
Conversation
servusdei2018
changed the title
ISC003 autofix incorrectly stripping + from commentsISC003 autofix incorrectly stripping + from comments
MichaReiser
added
bug
|
MichaReiser
reviewed
Jul 6, 2026
Comment on lines
+131
to
+133
| // Fallback in case of unexpected token structure | ||
| between_operands.split_once('+').unwrap() | ||
| }; |
Member
There was a problem hiding this comment.
I don't think we need this fallback. It's as likely to panic as if we can't find the token in the token stream.
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26541
Summary
Fixes a bug in the
ISC003(explicit-string-concatenation) autofix where+characters inside inline comments (e.g.# Complains about this: +) were incorrectly stripped instead of the actual+binary operator.Test Plan
+within inline comments to theISC.pytest fixture.cargo test -p ruff_linter -- flake8_implicit_str_concatto update the snapshots and verify correctness.