Skip to content

Inline formatter printing hot paths #26504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 3 commits into from
Jul 2, 2026
+7 −0
Merged

Inline formatter printing hot paths #26504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4215159
Inline formatter printing hot paths
charliermarsh Jul 1, 2026
f0e998d
Fix inline-always Clippy lint
charliermarsh Jul 1, 2026
1521be2
Omit inline-always expect reason
charliermarsh Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/ruff_formatter/src/printer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ impl<'a> Printer<'a> {
}

/// Prints a single element and push the following elements to queue
// LLVM considers this function too large to inline on its own, but it is called for every

@MichaReiser MichaReiser Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM does have a point, given that the function is called twice. But it's probably fine, we may want to reconsider if the function is ever called in three places.

// element visited by the printing loop.
#[inline(always)]
fn print_element(
&mut self,
stack: &mut PrintCallStack,
Expand Down Expand Up @@ -438,6 +441,10 @@ impl<'a> Printer<'a> {
Ok(print_mode)
}

// LLVM considers this function too large to inline on its own, but it is called for every
// text element visited by the printing loop.
#[expect(clippy::inline_always)]
#[inline(always)]
fn print_text(&mut self, text: Text) {
if !self.state.pending_indent.is_empty() {
let indent = std::mem::take(&mut self.state.pending_indent);
Expand Down
Loading