[flake8-pytest-style] Mark PT022 fixes as unsafe - #26440
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c88539d3ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ntBre
changed the title
flake8-pytest-style] Mark PT022 fixes as unsafe
ntBre
approved these changes
Jul 29, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I resolved the merge conflicts and added a fix safety section to the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the diagnostic fix applicability for rule
PT022(missing yield types / old-style yield fixtures) from a safe edit to anunsafe_edit.Converting a
yieldto areturnfundamentally alters execution flow, scope lifetimes, and teardown behavior. In certain contexts (e.g., when interacting with bindings like GDAL), this transformation can cause critical runtime failures such as segmentation faults. Forcing this to be an unsafe fix ensures that it will not be executed blindly during a standard--fixpass without explicit opt-in via--allow-unsafe-fixes.Fixes #26332
Test Plan
Updated the companion snapshot test (
PT022.snap) usinginstato verify that the generated diagnostic now correctly appends the trailing note:note: This is an unsafe fix and may change runtime behavior. All relevant linter tests now pass cleanly.