Replace unmaintained unic-ucd-category crate with icu_properties#24344
Replace unmaintained unic-ucd-category crate with icu_properties#24344MichaReiser merged 3 commits intoastral-sh:mainfrom
unic-ucd-category crate with icu_properties#24344Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.76%. The percentage of expected errors that received a diagnostic held steady at 81.53%. The number of fully passing files held steady at 70/132. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 41 | 0 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
ShaharNaveh
force-pushed
the
replace-unmaintained-unic
branch
from
902d4ed to
c07c57b
Compare
|
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thank you. This makes sense. But we should revert the unrelated dependency version bumps. We intentionally only depend on dependencies that are at least 7 days old and it seems this PR bumps some of them.
| !(cat.is_other() || cat.is_separator()) | ||
| let cat = GeneralCategory::for_char(c); | ||
|
|
||
| !matches!( |
There was a problem hiding this comment.
Nit: Let's reorder them so that they match the doc-comment
Cargo.lock
Outdated
| ] | ||
|
|
||
| [[package]] | ||
| name = "async-trait" |
There was a problem hiding this comment.
Ruff doesn't use any async code. It would be nice if we can disable whatever feature/dependency depends on async-trait
Cargo.lock
Outdated
| [[package]] | ||
| name = "futures-core" | ||
| version = "0.3.32" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "7e3450815272ef58cec6d564423f6e755e25379b217b0bc688e295ba24df6b1d" | ||
|
|
||
| [[package]] | ||
| name = "futures-task" | ||
| version = "0.3.32" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "037711b3d59c33004d3856fbdc83b99d4ff37a24768fa1be9ce3538a1cde4393" | ||
|
|
||
| [[package]] | ||
| name = "futures-util" | ||
| version = "0.3.32" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "389ca41296e6190b48053de0321d02a77f32f8a5d2461dd38762c0593805c6d6" | ||
| dependencies = [ | ||
| "futures-core", | ||
| "futures-task", | ||
| "pin-project-lite", | ||
| "slab", | ||
| ] | ||
|
|
There was a problem hiding this comment.
Same here. These dependencies seem unnecessary in Ruff's context. Is there a way to disable a feature flag to remove the dependency?
Cargo.lock
Outdated
| [[package]] | ||
| name = "inotify" | ||
| version = "0.11.0" | ||
| version = "0.11.1" |
There was a problem hiding this comment.
Can you revert your changes and start with a "clean" Cargo.lock. Many of the dependency upgrades seem unrelated to replacing the dependency
Cargo.lock
Outdated
| checksum = "2e04e2ef80ce82e13552136fabeef8a5ed1f985a96805761cbb9a2c34e7664d9" | ||
| dependencies = [ | ||
| "cfg-if", | ||
| "futures-util", |
There was a problem hiding this comment.
This is where the problematic dependencies come from. Might be worth checking if js-sys has a feature flag to disable the future stuff
Sure! I had to regenerate the lock file for some reason, that's why the large change to |
|
Restoring the lock file and then running |
* main: Add a "release-gate" step to the release workflow (#24365) Disallow starred expressions as values of starred expressions (#24280) [`pyupgrade`] Ignore strings with string-only escapes (`UP012`) (#16058) [ty] Improve consistency and quality of diagnostics relating to invalid type forms (#24325) [flake8-type-checking] Clarify import cycle wording for TC001/TC002/TC003 (#24322) [`flake8-errmsg`] Avoid shadowing existing `msg` in fix for `EM101` (#24363) `RUF072`: skip formfeeds on dedent (#24308) Replace unmaintained `unic-ucd-category` crate with `icu_properties` (#24344) [ty] Replace markdown hard line breaks in snapshot tests (#24361) [ty] Move snapshot for code action test with trailing whitespace to external file (#24359)
2 participants
Summary
The
unic-ucd-categorycrate is unmaintained (see rustsec/advisory-db#2424)Test Plan
I've made a PR for RustPython at: RustPython/RustPython#7555 that passed the CPython test suite (the failing tests are because of implementation details related to RustPython)