Don't measure the AST deallocation time in parser benchmarks#24301
Merged
MichaReiser merged 1 commit intomainfrom Mar 30, 2026
Merged
Don't measure the AST deallocation time in parser benchmarks#24301MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
MichaReiser
force-pushed
the
micha/parser-benchmark-dealloc
branch
2 times, most recently
from
b6252cc to
7c8674b
Compare
Merging this PR will improve performance by 8.05%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | parser[numpy/ctypeslib.py] |
964.5 µs | 902.5 µs | +6.87% |
| ⚡ | Simulation | parser[large/dataset.py] |
5.2 ms | 4.9 ms | +6.04% |
| ⚡ | Simulation | parser[unicode/pypinyin.py] |
336.6 µs | 314.6 µs | +6.99% |
| ⚡ | Simulation | parser[pydantic/types.py] |
2 ms | 1.9 ms | +8.05% |
| ⚡ | Simulation | parser[numpy/globals.py] |
111.6 µs | 105.4 µs | +5.8% |
Comparing micha/parser-benchmark-dealloc (1ce7a03) with main (bd477d9)
MichaReiser
force-pushed
the
micha/parser-benchmark-dealloc
branch
from
7c8674b to
1ce7a03
Compare
carljm
added a commit
that referenced
this pull request
Mar 31, 2026
* main: (35 commits) Store definition indexes as u32 (#24307) Avoid re-using symbol in RUF024 fix (#24316) [ty] Add materialization to `Divergent` type (#24255) [ty] Make `Divergent` a top-level type variant (#24252) [ty] Fix nested global and nonlocal lookups through forwarding scopes (#24279) Fetch the cargo-dist binary directly instead of using the installer (#24258) [ty] Fix panic on `list[Annotated[()]]` (#24303) Don't measure the AST deallocation time in parser benchmarks (#24301) Enable CodSpeed's memory benchmarks for simulation benchmarks (#24298) Upgrade imara-diff to 0.2.0 (#24299) [ty] Represent `InitVar` as a special form internally, not a class (#24248) `RUF067`: Allow dunder-named assignments in non-strict mode [`pyupgrade`] UP018 should detect more unnecessarily wrapped literals (UP018) (#24093) [ty] Remove unused `system.glob` method (#24300) [ty] Reject functional TypedDict with mismatched name (#24295) Update Rust crate arc-swap to v1.9.0 (#24292) [ty] Remove unused `@Todo(Functional TypedDicts)` (#24297) Update CodSpeedHQ/action action to v4.12.1 (#24290) Update taiki-e/install-action action to v2.69.6 (#24293) Update Rust crate toml to v1.0.7 (#24289) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Looking at CodSpeeds memory profiles made me realize that
our parser benchmarks include the AST deallocation time. That's not really what we're interested in.
This PR excludes the deallocation time from what's measured in the benchmarks.
Test Plan
CI