Skip to content

Enable CodSpeed's memory benchmarks for simulation benchmarks #24298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaReiser merged 4 commits into from
Mar 30, 2026
+34 −94
Merged

Enable CodSpeed's memory benchmarks for simulation benchmarks #24298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
893bcb6
Enable memory benchmarks
MichaReiser Mar 30, 2026
74ccdc4
Update codspeed dependencies
MichaReiser Mar 30, 2026
cb35511
Disable for walltime benchmarks because it takes too long
MichaReiser Mar 30, 2026
4d39877
split memory/simulation runs
MichaReiser Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,12 +998,12 @@ jobs:
tool: cargo-codspeed

- name: "Build benchmarks"
run: cargo codspeed build --features "codspeed,ruff_instrumented" --profile profiling --no-default-features -p ruff_benchmark --bench formatter --bench lexer --bench linter --bench parser
run: cargo codspeed build -m simulation -m memory --features "codspeed,ruff_instrumented" --profile profiling --no-default-features -p ruff_benchmark --bench formatter --bench lexer --bench linter --bench parser

- name: "Run benchmarks"
uses: CodSpeedHQ/action@1c8ae4843586d3ba879736b7f6b7b0c990757fab # v4.12.1
with:
mode: simulation
mode: "simulation,memory"
run: cargo codspeed run

benchmarks-instrumented-ty-build:
Expand Down Expand Up @@ -1037,7 +1037,7 @@ jobs:
tool: cargo-codspeed

- name: "Build benchmarks"
run: cargo codspeed build -m instrumentation --features "codspeed,ty_instrumented" --profile profiling --no-default-features -p ruff_benchmark --bench ty
run: cargo codspeed build -m simulation -m memory --features "codspeed,ty_instrumented" --profile profiling --no-default-features -p ruff_benchmark --bench ty

- name: "Upload benchmark binary"
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
Expand All @@ -1048,7 +1048,7 @@ jobs:
retention-days: 1

benchmarks-instrumented-ty-run:
name: "benchmarks instrumented ty (${{ matrix.benchmark }})"
name: "benchmarks instrumented ty (${{matrix.mode}}: ${{ matrix.benchmark }})"
runs-on: ubuntu-24.04
needs: benchmarks-instrumented-ty-build
timeout-minutes: 20
Expand All @@ -1061,6 +1061,9 @@ jobs:
benchmark:
- "check_file|micro|anyio"
- "attrs|hydra|datetype"
mode:
- simulation
- memory
steps:
- name: "Checkout Branch"
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down Expand Up @@ -1088,7 +1091,7 @@ jobs:
- name: "Run benchmarks"
uses: CodSpeedHQ/action@1c8ae4843586d3ba879736b7f6b7b0c990757fab # v4.12.1
with:
mode: simulation
mode: ${{ matrix.mode }}
run: cargo codspeed run --bench ty "${{ matrix.benchmark }}"

benchmarks-walltime-build:
Expand Down
111 changes: 24 additions & 87 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ camino = { version = "1.1.7" }
clap = { version = "4.5.3", features = ["derive"] }
clap_complete_command = { version = "0.6.0" }
clearscreen = { version = "4.0.0" }
codspeed-criterion-compat = { version = "4.0.4", default-features = false }
codspeed-criterion-compat = { version = "4.4.1", default-features = false }
colored = { version = "3.0.0" }
compact_str = "0.9.0"
console_error_panic_hook = { version = "0.1.7" }
Expand All @@ -85,7 +85,7 @@ crossbeam = { version = "0.8.4" }
csv = { version = "1.3.1" }
dashmap = { version = "6.0.1" }
datatest-stable = { version = "0.3.3" }
divan = { package = "codspeed-divan-compat", version = "4.0.4" }
divan = { package = "codspeed-divan-compat", version = "4.4.1" }
drop_bomb = { version = "0.1.5" }
dunce = { version = "1.0.5" }
etcetera = { version = "0.11.0" }
Expand Down
Loading