Match .editorconfig and pre commit hook on trailing white space#24266
Closed
Glyphack wants to merge 1 commit intoastral-sh:mainfrom
Closed
Match .editorconfig and pre commit hook on trailing white space#24266Glyphack wants to merge 1 commit intoastral-sh:mainfrom
Glyphack wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Glyphack
requested review from
AlexWaygood,
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
|
Contributor
Author
|
So the whitespaces where there on purpose. For now I exclude that file from .editorconfig to discuss this and see what's the solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While I was working on a change on
crates/ty_ide/src/hover.rsI noticed trailing new lines are trimmed on saving the file. I'm using neovim.I searched around and found out the reason is .editorconfig. Without this setting editor won't reformat the code anymore.
But since it's not bad to trim new lines we just need it to be consistent I added it to pre commit hooks. Not a lot of files have trailing whitespace.
Update: I didn't realize this initially but the whitespace is in the result snapshot not the source code so trimming it will make tests fail. I'm checking what can I do.
Test Plan