[ty] Used shared expression cache during generic call narrowing#24237
Closed
ibraheemdev wants to merge 1 commit intomainfrom
Closed
[ty] Used shared expression cache during generic call narrowing#24237ibraheemdev wants to merge 1 commit intomainfrom
ibraheemdev wants to merge 1 commit intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.59%. The percentage of expected errors that received a diagnostic held steady at 80.96%. The number of fully passing files held steady at 68/132. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unresolved-attribute |
0 | 6 | 0 |
possibly-unresolved-reference |
0 | 4 | 0 |
invalid-argument-type |
0 | 3 | 0 |
missing-argument |
0 | 2 | 0 |
no-matching-overload |
0 | 2 | 0 |
unsupported-operator |
0 | 1 | 0 |
| Total | 0 | 18 | 0 |
Raw diff (18 changes)
colour (https://github.com/colour-science/colour)
- colour/plotting/models.py:1066:21 error[invalid-argument-type] Argument to function `RGB_to_RGB` is incorrect: Expected `bool`, found `int | str | float | Any`
core (https://github.com/home-assistant/core)
- homeassistant/components/recorder/statistics.py:1532:29 warning[possibly-unresolved-reference] Name `new_max` used when possibly not defined
- homeassistant/components/recorder/statistics.py:1550:29 warning[possibly-unresolved-reference] Name `new_min` used when possibly not defined
django-stubs (https://github.com/typeddjango/django-stubs)
- mypy_django_plugin/lib/helpers.py:261:40 warning[possibly-unresolved-reference] Name `model_type` used when possibly not defined
freqtrade (https://github.com/freqtrade/freqtrade)
- freqtrade/exchange/exchange_utils.py:350:40 warning[possibly-unresolved-reference] Name `res` used when possibly not defined
ibis (https://github.com/ibis-project/ibis)
- ibis/expr/datatypes/tests/test_value.py:77:56 error[missing-argument] No argument provided for required parameter `value_type`
- ibis/expr/datatypes/tests/test_value.py:77:56 error[missing-argument] No argument provided for required parameter `value_type`
- ibis/expr/datatypes/tests/test_value.py:77:65 error[invalid-argument-type] Argument is incorrect: Expected `bool`, found `Float64`
- ibis/expr/datatypes/tests/test_value.py:77:65 error[invalid-argument-type] Argument is incorrect: Expected `bool`, found `Float64`
meson (https://github.com/mesonbuild/meson)
- mesonbuild/backend/vs2010backend.py:1994:78 error[unresolved-attribute] Attribute `get_build_dir` is not defined on `None` in union `Environment | None`
pandas (https://github.com/pandas-dev/pandas)
- pandas/core/groupby/grouper.py:655:62 error[unresolved-attribute] Attribute `ordered` is not defined on `Index`, `ndarray[tuple[Any, ...], dtype[Any]]` in union `Unknown | Index | ndarray[tuple[Any, ...], dtype[Any]] | Categorical`
- pandas/core/indexes/interval.py:1466:46 error[unsupported-operator] Operator `*` is not supported between objects of type `Number | number[Any, int | float | complex] | None | Unknown` and `float`
pandera (https://github.com/pandera-dev/pandera)
- tests/pandas/test_schema_statistics.py:58:33 error[no-matching-overload] No overload of function `to_datetime` matches arguments
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/server/database/dependencies.py:298:24 error[unresolved-attribute] Object of type `Self@__doc__` has no attribute `_func`
- src/prefect/server/database/dependencies.py:334:24 error[unresolved-attribute] Object of type `Self@__doc__` has no attribute `_func`
pycryptodome (https://github.com/Legrandin/pycryptodome)
- lib/Crypto/PublicKey/RSA.py:180:44 error[unresolved-attribute] Object of type `Self@_encrypt` has no attribute `_e`
- lib/Crypto/PublicKey/RSA.py:180:53 error[unresolved-attribute] Object of type `Self@_encrypt` has no attribute `_n`
xarray (https://github.com/pydata/xarray)
- xarray/tests/test_groupby.py:805:30 error[no-matching-overload] No overload of function `cut` matches arguments
Merging this PR will improve performance by 12.02%
Performance Changes
Comparing Footnotes
|
Member
Author
|
Nevermind, we can't actually do it in this case, we need each speculative attempt to have independent diagnostics. Unless there was a separate diagnostics cache... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the expression cache added in #24219 more generally.