Skip to content

[eradicate] ignore ty: ignore comments in ERA001#24192

Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom
bitloi:fix/issue-24186-era001-ty-ignore
Mar 26, 2026
Merged

[eradicate] ignore ty: ignore comments in ERA001#24192
MichaReiser merged 1 commit intoastral-sh:mainfrom
bitloi:fix/issue-24186-era001-ty-ignore

Conversation

@bitloi
Copy link
Copy Markdown
Contributor

@bitloi bitloi commented Mar 25, 2026

Summary

Don't flag # ty: ignore comments as commented-out code.

Closes #24186

Test Plan

New unit tests and fixture case.

@astral-sh-bot astral-sh-bot bot requested a review from amyreese March 25, 2026 22:56
@bitloi bitloi changed the title [eradicate] ignore ty: ignore comments in ERA001 (#24186) [eradicate] ignore ty: ignore comments in ERA001 Mar 26, 2026
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Mar 26, 2026
@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Mar 26, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser merged commit 6c2e268 into astral-sh:main Mar 26, 2026
42 checks passed
@bitloi
Copy link
Copy Markdown
Contributor Author

bitloi commented Mar 26, 2026

@MichaReiser Thanks for your quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop flagging # ty: annotations as commented-out code

3 participants