[ty] Restore IsNonTerminalCall shortcut optimization (again)#24185
Merged
[ty] Restore IsNonTerminalCall shortcut optimization (again)#24185
IsNonTerminalCall shortcut optimization (again)#24185Conversation
sharkdp
changed the title
IsNonTerminalCall shortcut optimization (again)
sharkdp
commented
Mar 25, 2026
Contributor
Author
There was a problem hiding this comment.
I made some attempts to minify this and/or change it to something that is easier in structure, but eventually decided to simply use the version from the issue.
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.46%. The percentage of expected errors that received a diagnostic held steady at 80.68%. The number of fully passing files held steady at 67/132. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
trio
flake8
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
1 | 0 | 0 |
invalid-assignment |
1 | 0 | 0 |
invalid-return-type |
0 | 0 | 1 |
type-assertion-failure |
1 | 0 | 0 |
| Total | 3 | 0 | 1 |
Raw diff:
egglog-python (https://github.com/egraphs-good/egglog-python)
+ python/egglog/egraph.py:2139:24 error[invalid-argument-type] Argument to function `expr_action` is incorrect: Expected `BaseExpr`, found `(BaseExpr & ~Action) | (Fact & ~Action)`
hydpy (https://github.com/hydpy-dev/hydpy)
+ hydpy/core/devicetools.py:2425:9 error[type-assertion-failure] Type `Literal["inlets", "outlets", "observers", "receivers", "senders", "inputs", "outputs"]` is not equivalent to `Never`
pydantic (https://github.com/pydantic/pydantic)
- pydantic/v1/utils.py:613:16 error[invalid-return-type] Return type does not match returned value: expected `Mapping[int | str, Any]`, found `(AbstractSet[int | str] & Top[Mapping[Unknown, object]]) | Mapping[int | str, Any] | dict[int | str, ellipsis]`
+ pydantic/v1/utils.py:613:16 error[invalid-return-type] Return type does not match returned value: expected `Mapping[int | str, Any]`, found `(AbstractSet[int | str] & Top[Mapping[Unknown, object]]) | (Mapping[int | str, Any] & AbstractSet[object]) | (Mapping[int | str, Any] & ~AbstractSet[object]) | dict[int | str, ellipsis]`
trio (https://github.com/python-trio/trio)
+ src/trio/_core/_tests/test_run.py:2440:24 error[invalid-assignment] Object of type `Value[object] | Error` is not assignable to `Outcome[str] | None`
Merging this PR will not alter performance
Performance Changes
Comparing 
|
Contributor
Author
|
It's very unfortunate that I need to acknowledge a (small) performance regression on pandas in order to fix this performance regression in astral-sh/ty#3120, but I currently see no other way. |
sharkdp
requested review from
AlexWaygood,
carljm,
dcreager and
ibraheemdev
as code owners
carljm
approved these changes
Mar 25, 2026
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Too bad :/ Thanks for exploring!
Contributor
Author
|
the new benchmark is currently timing out after my last commit. need to take another look tomorrow. |
Member
shows you wrote an effective regression benchmark! |
This reverts commit 5348e47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I tried a few other things, but none of them worked, so for now, let's just revert a2c5af0 (again). Note that it's not an exact revert because we renamed
NoReturn->IsNonTerminalCalland inverted the logic in between.Also, I fixed the bug that was described in the original PR (#23378).closes astral-sh/ty#3120
Note for reviewers: The only thing that's really new here is the benchmark,
and the changes in the second commit (5348e47).Test Plan
New benchmark