fix: suppress SIM105 for except* (fixes #23798)#24139
Closed
r266-tech wants to merge 1 commit intoastral-sh:mainfrom
Closed
fix: suppress SIM105 for except* (fixes #23798)#24139r266-tech wants to merge 1 commit intoastral-sh:mainfrom
r266-tech wants to merge 1 commit intoastral-sh:mainfrom
Conversation
SIM105 suggested replacing 'except* ...: pass' with contextlib.suppress(), but contextlib.suppress doesn't support BaseExceptionGroup until Python 3.12. This fix ensures SIM105 is not triggered when using except* syntax.
Contributor
|
Thanks, but there's already an open PR for this issue: #23869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23798.
SIM105 suggests replacing
except* ...: passwithcontextlib.suppress(), butcontextlib.suppressonly gained support forBaseExceptionGroupin Python 3.12. This means the suggested fix is incorrect for Python 3.11 when usingexcept*syntax.Changes
is_starparameter tosuppressible_exception()functionexcept*, skip the SIM105 rule entirelySIM105_5.pyto verifyexcept*cases are not flaggedRationale
As described in the issue,
except*handlesBaseExceptionGroup, andcontextlib.suppressdid not support exception groups until Python 3.12. Even when targeting Python 3.12+, the semantic equivalence is not guaranteed, so it's safest to suppress SIM105 for allexcept*cases.