Skip to content

[ty] Remove unused CycleDetector::try_visit method #23944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 1 commit into from
Mar 13, 2026
+0 −28
Merged

[ty] Remove unused CycleDetector::try_visit method #23944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions crates/ty_python_semantic/src/types/cyclic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,34 +131,6 @@ impl<Tag, T: Hash + Eq + Clone, R: Clone, Extra> CycleDetector<Tag, T, R, Extra>

ret
}

pub fn try_visit(&self, item: T, func: impl FnOnce() -> Option<R>) -> Option<R> {
if let Some(val) = self.cache.borrow().get(&item) {
return Some(val.clone());
}

// We hit a cycle
if !self.seen.borrow_mut().insert(item.clone()) {
return Some(self.fallback.clone());
}

// Check depth limit to prevent stack overflow from recursive generic protocols
// with growing specializations (e.g., C[set[T]] -> C[set[set[T]]] -> ...)
let current_depth = self.depth.get();
if current_depth >= MAX_RECURSION_DEPTH {
self.seen.borrow_mut().pop();
return Some(self.fallback.clone());
}
self.depth.set(current_depth + 1);

let ret = func()?;

self.depth.set(current_depth);
self.seen.borrow_mut().pop();
self.cache.borrow_mut().insert(item, ret.clone());

Some(ret)
}
}

impl<Tag, T: Hash + Eq + Clone, R: Default + Clone> Default for CycleDetector<Tag, T, R> {
Expand Down
Loading