Skip to content

[ty] Explicitly track the "support" of each constraint set#23716

Draft
dcreager wants to merge 10 commits intomainfrom
dcreager/add-support
Draft

[ty] Explicitly track the "support" of each constraint set#23716
dcreager wants to merge 10 commits intomainfrom
dcreager/add-support

Conversation

@dcreager
Copy link
Member

@dcreager dcreager commented Mar 4, 2026

description TBD

@dcreager dcreager added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Mar 4, 2026
@dcreager dcreager force-pushed the dcreager/add-support branch from 4f317c2 to d5969aa Compare March 4, 2026 18:35
@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 4, 2026

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 86.95%. The percentage of expected errors that received a diagnostic held steady at 77.43%.

@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 4, 2026

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 4, 2026

mypy_primer results

Changes were detected when running on open source projects
discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/converter.py:381:16: error[invalid-return-type] Return type does not match returned value: expected `tuple[int | None, int, int]`, found `tuple[(Guild & ~AlwaysTruthy) | None | int, int, int]`
+ discord/ext/commands/converter.py:381:16: error[invalid-return-type] Return type does not match returned value: expected `tuple[int | None, int, int]`, found `tuple[None | (Guild & ~AlwaysTruthy) | int, int, int]`

@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 4, 2026

ecosystem-analyzer results

Lint rule Added Removed Changed
invalid-return-type 0 0 1
Total 0 0 1

Full report with detailed diff (timing results)

Base automatically changed from dcreager/fix-source-order to main March 5, 2026 20:00
@dcreager dcreager force-pushed the dcreager/add-support branch from df5302e to 2b07c2c Compare March 5, 2026 20:08
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2026

Merging this PR will degrade performance by 4.34%

❌ 1 regressed benchmark
✅ 25 untouched benchmarks
⏩ 30 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime colour_science 111.1 s 116.1 s -4.34%

Comparing dcreager/add-support (2b07c2c) with main (f9324a5)

Open in CodSpeed

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecosystem-analyzer internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant