Fixes UP032 crash with raw strings containing \N{#23422
Closed
IMaloney wants to merge 1 commit intoastral-sh:mainfrom
Closed
Fixes UP032 crash with raw strings containing \N{#23422IMaloney wants to merge 1 commit intoastral-sh:mainfrom
IMaloney wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Skip conversion when raw strings contain \N{ patterns.
In raw strings \N is literal, but f-strings evaluate {name} as a variable,
causing NameError.
Fixes astral-sh#22060
Contributor
|
Thanks for working on this, but it looks like there's already an open PR for this issue: #22149. So I'll close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UP032 crash with raw strings containing
\\N{(#22060)Here we are converting raw strings like
r"\\N{angle}".format(angle=180)to f-strings. Converting torf"\\N{angle}"makes the f-string try to evaluate{angle}as a variable instead of keeping it as format syntax, which causesNameError.Let's add a check to skip conversion when raw strings contain
\\N{patterns.Test Plan
Manual testing with the exact code from the issue:
Added test case to
UP032_0.pyfixture file.