-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Expand the default rule set #23385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Expand the default rule set #23385
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
78210c0
add PREVIEW_DEFAULT_RULES and a test
ntBre bd206cd
include proposed rules as individual selectors
ntBre 339b8b5
clippy and update other tests
ntBre 5608fba
update rule docs
ntBre 0d2bf9b
remove rules from discussion
ntBre 24e34ed
remove rules from discussion
ntBre 5acf5d5
update snapshots
ntBre 189c7e5
allow links to preview
ntBre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally sold on including this, especially in the README (but this is how the top of our Rules page is generated). I'd be happy just to put something like this in the release notes instead, but I'm curious what others think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like including this, but should probably also say something along the lines of "and this will be the default set in a future minor release"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me that's kind of implied by referencing preview, but I don't feel too strongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it here, and I agree with you that "in a future minor" is implicit. (In fact - if people don't like them in preview, then they won't be stabilized in a future minor!)