[ty] support narrowing from Callable returning type guard#23280
Merged
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
4c3ebaf to
a24a326
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
0 | 2 | 27 |
invalid-await |
0 | 15 | 0 |
unresolved-attribute |
0 | 0 | 6 |
invalid-assignment |
0 | 1 | 2 |
redundant-cast |
3 | 0 | 0 |
unsupported-operator |
0 | 0 | 3 |
invalid-return-type |
0 | 0 | 1 |
| Total | 3 | 18 | 39 |
AlexWaygood
approved these changes
Feb 15, 2026
carljm
added a commit
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We only narrowed from TypeIs/TypeGuard if the callable was a FunctionLiteral or BoundMethod type. We should be willing to do this narrowing for any TypeIs/TypeGuard type returned from any call expression.
Test Plan
Added mdtest.