[ruff] add import annotations for UP007 & UP045#23259
Open
11happy wants to merge 4 commits intoastral-sh:mainfrom
Open
[ruff] add import annotations for UP007 & UP045#2325911happy wants to merge 4 commits intoastral-sh:mainfrom
11happy wants to merge 4 commits intoastral-sh:mainfrom
Conversation
11happy
force-pushed
the
import_annotation_for_UP007_and_UP045
branch
from
4bf8c65 to
768f4c2
Compare
|
ntBre
requested changes
Feb 20, 2026
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
See my comment on #23260 (review). I think this PR has the same issues. It's probably best to get one of these landed and then apply the same approach to the other instead of updating them both in parallel since I think they'll be quite similar.
ntBre
added
rule
Contributor
Author
|
Making it draft as once UP006 lands I will update this similarly here. |
11happy
force-pushed
the
import_annotation_for_UP007_and_UP045
branch
from
768f4c2 to
c03e495
Compare
Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com> missing snap Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com> update snaps Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com> add snaps Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com>
11happy
force-pushed
the
import_annotation_for_UP007_and_UP045
branch
from
7460d0c to
6b36c53
Compare
Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com>
Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com>
Signed-off-by: Bhuminjay <bhuminjaysoni@gmail.com>
Contributor
Author
|
Its ready for review kept it similar to UP006. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
part of #19359
Test Plan
added tests & snapshots