[ty] Emit diagnostic on unbound call to abstract @classmethod or @staticmethod#23182
Merged
charliermarsh merged 3 commits intomainfrom Feb 10, 2026
Merged
[ty] Emit diagnostic on unbound call to abstract @classmethod or @staticmethod#23182charliermarsh merged 3 commits intomainfrom
@classmethod or @staticmethod#23182charliermarsh merged 3 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
call-abstract-method |
6 | 0 | 0 |
| Total | 6 | 0 | 0 |
add1990 to
02751e4
Compare
|
02751e4 to
b20822c
Compare
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
prefect
sphinx
trio
|
AlexWaygood
requested changes
Feb 10, 2026
AlexWaygood
reviewed
Feb 10, 2026
crates/ty_python_semantic/resources/mdtest/call/abstract_method.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/call/abstract_method.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/call/abstract_method.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/call/abstract_method.md
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Feb 10, 2026
b20822c to
35e0455
Compare
35e0455 to
5ba9f1b
Compare
AlexWaygood
reviewed
Feb 10, 2026
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks good now, thank you!
AlexWaygood
pushed a commit
that referenced
this pull request
Feb 15, 2026
Summarise the guidance from #23182 (discussion_r2786953726): methods that access .node() on Salsa-tracked types must be #[salsa::tracked], and higher-level semantic APIs should be preferred over raw AST access to preserve incrementality. https://claude.ai/code/session_01VcvJoy5txSavsYH15JbJnZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#1927.