Open
Conversation
Typing conformance resultsNo changes detected ✅ |
4f5f14c to
876eead
Compare
|
d90ba3d to
171e68c
Compare
171e68c to
5ec4d35
Compare
Member
Author
|
I'll mark as draft pending #22792. |
5ec4d35 to
dce1aba
Compare
Memory usage reportMemory usage unchanged ✅ |
326f180 to
ac8a81b
Compare
ac8a81b to
db7116d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generally straightforward given that we support
type(...); however, I think the base class validation can be a bit looser, sincetypes.new_classdoes proper metaclass resolution.Closes astral-sh/ty#2399.