Conversation
Summary -- I noticed this while reviewing #22990 Test Plan --
dylwil3
approved these changes
Feb 2, 2026
Member
|
I've seen this before, related to how some parsers treat binding order within certain parts of the syntax. It should work the way it was, but better to be explicit here I think. |
amyreese
approved these changes
Feb 2, 2026
ntBre
changed the title
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed this while reviewing #22990. I'm not really sure why the current version doesn't work, but the new one definitely does.
Test Plan
Before:
After: