Skip to content

Stabilize checking additional key expression types in SIM910#22976

Merged
ntBre merged 3 commits intobrent/0.15.0from
brent/sim910_expanded_key_support-0.15.0
Jan 30, 2026
Merged

Stabilize checking additional key expression types in SIM910#22976
ntBre merged 3 commits intobrent/0.15.0from
brent/sim910_expanded_key_support-0.15.0

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Jan 30, 2026

Added in #20343

@ntBre ntBre added this to the v0.15 milestone Jan 30, 2026
@ntBre ntBre added the rule Implementing or modifying a lint rule label Jan 30, 2026
@ntBre ntBre requested review from amyreese and dylwil3 January 30, 2026 15:04
@astral-sh-bot
Copy link

astral-sh-bot bot commented Jan 30, 2026

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+6 -0 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)

apache/superset (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --no-preview --select ALL

+ superset/commands/database/tables.py:143:34: SIM910 [*] Use `extra_dict_by_name.get(table.table)` instead of `extra_dict_by_name.get(table.table, None)`

binary-husky/gpt_academic (+1 -0 violations, +0 -0 fixes)

+ request_llms/bridge_all.py:1304:31: SIM910 [*] Use `dict.get()` without default value

zulip/zulip (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --no-preview --select ALL

+ zerver/models/users.py:733:28: SIM910 [*] Use `user_data.get(field.id)` instead of `user_data.get(field.id, None)`
+ zerver/tornado/event_queue.py:1230:49: SIM910 [*] Use `extra_user_data.get(client.user_profile_id)` instead of `extra_user_data.get(client.user_profile_id, None)`

astropy/astropy (+2 -0 violations, +0 -0 fixes)

+ astropy/table/mixins/registry.py:66:16: SIM910 [*] Use `dict.get()` without default value
+ astropy/wcs/wcsapi/fitswcs.py:287:34: SIM910 [*] Use `CTYPE_TO_UCD1.get(ctype_name.upper())` instead of `CTYPE_TO_UCD1.get(ctype_name.upper(), None)`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
SIM910 6 6 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre marked this pull request as ready for review January 30, 2026 17:15
@ntBre ntBre merged commit 4cbc935 into brent/0.15.0 Jan 30, 2026
41 checks passed
@ntBre ntBre deleted the brent/sim910_expanded_key_support-0.15.0 branch January 30, 2026 18:27
@ntBre ntBre mentioned this pull request Jan 30, 2026
3 tasks
ntBre added a commit that referenced this pull request Feb 3, 2026
ntBre added a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants