Merged
Conversation
Closes #22816. As I note on the issue, I was previously hesitant to stabilize this rule because of its long `## Fix safety` docs and the TODO comment in the source code. However, the behavior change in the docs is simply handled by making the fix unsafe, and resolving the TODO shouldn't require a breaking change. It will only allow the fix to be offered in more cases. The docs and tests looked good.
|
amyreese
approved these changes
Jan 28, 2026
dylwil3
approved these changes
Jan 29, 2026
ntBre
added a commit
that referenced
this pull request
Feb 3, 2026
Closes #22816. As I note on the issue, I was previously hesitant to stabilize this rule because of its long `## Fix safety` docs and the TODO comment in the source code. However, the behavior change in the docs is simply handled by making the fix unsafe, and resolving the TODO shouldn't require a breaking change. It will only allow the fix to be offered in more cases. The docs and tests looked good.
ntBre
added a commit
that referenced
this pull request
Feb 3, 2026
Closes #22816. As I note on the issue, I was previously hesitant to stabilize this rule because of its long `## Fix safety` docs and the TODO comment in the source code. However, the behavior change in the docs is simply handled by making the fix unsafe, and resolving the TODO shouldn't require a breaking change. It will only allow the fix to be offered in more cases. The docs and tests looked good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22816. As I note on the issue, I was previously hesitant to stabilize
this rule because of its long
## Fix safetydocs and the TODO comment in thesource code. However, the behavior change in the docs is simply handled by
making the fix unsafe, and resolving the TODO shouldn't require a breaking
change. It will only allow the fix to be offered in more cases.
The docs and tests looked good.