Merged
Conversation
I made one tweak to the diagnostic message to include backticks, but the docs and tests otherwise looked good.
|
amyreese
approved these changes
Jan 28, 2026
Collaborator
|
Unrelated: do we need more representation of |
dylwil3
approved these changes
Jan 29, 2026
Contributor
Author
|
That could certainly be the case! I think these issues are fairly severe, so maybe they get caught naturally, though? For this one in particular, I don't think This is a pretty rough check, but this seems like a fairly reasonable number of At least it's not zero 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made one tweak to the diagnostic message to include backticks, but the docs
and tests otherwise looked good.