Skip to content

Update MSRV to 1.91#22874

Merged
ntBre merged 3 commits intomainfrom
brent/rust-1.91
Jan 27, 2026
Merged

Update MSRV to 1.91#22874
ntBre merged 3 commits intomainfrom
brent/rust-1.91

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Jan 26, 2026

Summary

  • Bump the Rust toolchain to 1.93
  • Bump our MSRV to 1.91

This latter change also allows us to drop our copy of ceil_char_boundary, which is now stable. I'm not 100% sure we want to do that, as the TextSize API seems nice, but we can if we want.

I quickly looked through the clippy release notes and didn't see exactly why this lint expectation is now unfulfilled, but that was the only new clippy diagnostic from the upgrade.

Note: I don't think we can land this until after we bump our conda-forge version in conda-forge/ruff-feedstock#318.

Test Plan

Existing tests

@ntBre ntBre added the release Related to the release process label Jan 26, 2026
@astral-sh-bot
Copy link

astral-sh-bot bot commented Jan 26, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@ntBre ntBre marked this pull request as ready for review January 27, 2026 00:33
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing the custom implementation.

@ntBre ntBre merged commit b211af4 into main Jan 27, 2026
46 checks passed
@ntBre ntBre deleted the brent/rust-1.91 branch January 27, 2026 13:36
@dcreager
Copy link
Member

Yesssssss! I've been waiting for std::iter::chain for ages!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Related to the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants