Merged
Conversation
|
dhruvmanila
approved these changes
Jan 27, 2026
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
I'm fine with removing the custom implementation.
Member
|
Yesssssss! I've been waiting for |
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This latter change also allows us to drop our copy of
ceil_char_boundary, which is now stable. I'm not 100% sure we want to do that, as theTextSizeAPI seems nice, but we can if we want.I quickly looked through the clippy release notes and didn't see exactly why this lint expectation is now unfulfilled, but that was the only new clippy diagnostic from the upgrade.
Note: I don't think we can land this until after we bump our conda-forge version in conda-forge/ruff-feedstock#318.
Test Plan
Existing tests