refactor(refurb): mark MetaClassABCMeta fix as unsafe if comments would be deleted#22824
Closed
LouisLau-art wants to merge 1 commit intoastral-sh:mainfrom
Closed
refactor(refurb): mark MetaClassABCMeta fix as unsafe if comments would be deleted#22824LouisLau-art wants to merge 1 commit intoastral-sh:mainfrom
LouisLau-art wants to merge 1 commit intoastral-sh:mainfrom
Conversation
…ld be deleted The fix for FURB180 involves a range deletion or replacement. If the range contains comments, it is now correctly marked as Unsafe to prevent accidental loss of code comments. Added a regression test case to verify this behavior.
Contributor
|
Thanks for looking into this, but the linked issue already has a PR fixing it (#22234). |
Author
|
Thanks for pointing that out! Sorry for the duplicate effort — I’ll close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22631.
The fix for FURB180 (metaclass=abc.ABCMeta) currently involves a range deletion (when not the first argument) or replacement. If this range contains comments, they are silently deleted.
This PR ensures the fix is marked as
Unsafewhenever comments are detected in the affected range, preventing accidental loss of code documentation.Regression tests added in
FURB180.py.