[ty] Use fluent style more, and reduce allocations, when constructing Parameters instances#22719
Merged
AlexWaygood merged 1 commit intomainfrom Jan 19, 2026
Merged
Conversation
… `Parameters` instances
Typing conformance resultsNo changes detected ✅ |
|
MichaReiser
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a standalone refactor pulled out of #22718. It shouldn't have any behaviour change associated with it.
The PR adds a new
Parameter::with_optional_default()method that makes it easier to use fluent style when constructingParameterinstances.Test Plan
existing tests