[refurb] Mark FURB180 fix as unsafe when comments would be deleted#22685
Closed
AndyBodnar wants to merge 1 commit intoastral-sh:mainfrom
Closed
[refurb] Mark FURB180 fix as unsafe when comments would be deleted#22685AndyBodnar wants to merge 1 commit intoastral-sh:mainfrom
AndyBodnar wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Fixes astral-sh#22631 The safe fix for FURB180 could delete comments between keyword arguments. This change checks if comments exist in the deletion range and marks the fix as unsafe if so.
Contributor
|
Thanks for working on this! But this is already resolved in #22234, so I'll close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22631
The safe fix for FURB180 could delete comments that appear between keyword arguments. For example:
The fix deletes from the previous argument to the end of the metaclass keyword, which would remove the comment. This change checks if any comments exist in that deletion range and marks the fix as unsafe if so.
Added a test case covering this scenario.