flake8-simplify: avoid unnecessary builtins import for SIM105#22358
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Jan 5, 2026
Merged
flake8-simplify: avoid unnecessary builtins import for SIM105#22358MichaReiser merged 1 commit intoastral-sh:mainfrom
MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #22334 by updating the
SIM105fix to useget_or_import_builtin_symbolforBaseException.Previously, the fix would always insert an unnecessary
import builtinsand usebuiltins.BaseException. This change ensures thatBaseExceptionis accessed directly as a builtin, only falling back to an explicit import if the name is shadowed.Test Plan
cargo test -p ruff_linter rule_suppressibleexceptioncargo insta review.SIM105tests passed after updating snapshots.