Conversation
Summary -- While going through all the rules I noticed a broken link in the S704 docs. (I then got really confused because it appeared to be correct in the _other_ `unsafe_markup_use.rs` file for the removed RUF version of the rule). Test Plan -- [Before](https://docs.astral.sh/ruff/rules/unsafe-markup-use/): After:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While going through all the rules I noticed a broken link in the S704 docs. (I then got really confused because it appeared to be correct in the other
unsafe_markup_use.rsfile for the removed RUF version of the rule).Test Plan
Before:
After:
I also did at least a cursory grep for other cases with escaped link brackets (
\[) and only turned up this rule on main.