Skip to content

[ty] Avoid caching trivial is-redundant-with calls#21989

Merged
MichaReiser merged 1 commit intomainfrom
micha/avoid-caching-trivial-is-redundant-with
Dec 15, 2025
Merged

[ty] Avoid caching trivial is-redundant-with calls#21989
MichaReiser merged 1 commit intomainfrom
micha/avoid-caching-trivial-is-redundant-with

Conversation

@MichaReiser
Copy link
Member

No description provided.

@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Dec 15, 2025
@astral-sh-bot
Copy link

astral-sh-bot bot commented Dec 15, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Dec 15, 2025

mypy_primer results

No ecosystem changes detected ✅

Memory usage changes were detected when running on open source projects
sphinx (https://github.com/sphinx-doc/sphinx)
-     memo metadata = ~80MB
+     memo metadata = ~76MB

@MichaReiser
Copy link
Member Author

This seems worth it even just from a memory standpoint

Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow yeah great win

@MichaReiser MichaReiser marked this pull request as ready for review December 15, 2025 17:44
@MichaReiser
Copy link
Member Author

Looks like a 1-2% performance improvement. I take it

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Dec 15, 2025
@MichaReiser MichaReiser merged commit 1df6544 into main Dec 15, 2025
43 checks passed
@MichaReiser MichaReiser deleted the micha/avoid-caching-trivial-is-redundant-with branch December 15, 2025 17:45
dcreager added a commit that referenced this pull request Dec 15, 2025
* origin/main:
  [ty] Consistent ordering of constraint set specializations, take 2 (#21983)
  [ty] Remove invalid statement-keyword completions in for-statements (#21979)
  [ty] Avoid caching trivial is-redundant-with calls (#21989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments